Clean up the FillToEdge action implementation
[dana/openbox.git] / openbox / actions / growtoedge.c
index b6979c9..3a21380 100644 (file)
@@ -7,31 +7,46 @@
 
 typedef struct {
     ObDirection dir;
+    gboolean shrink;
+    gboolean fill;
 } Options;
 
-static gpointer setup_func(ObParseInst *i, xmlDocPtr doc, xmlNodePtr node);
-static void     free_func(gpointer options);
+static gpointer setup_grow_func(xmlNodePtr node);
+static gpointer setup_fill_func(xmlNodePtr node);
+static gpointer setup_shrink_func(xmlNodePtr node);
+static void free_func(gpointer o);
 static gboolean run_func(ObActionsData *data, gpointer options);
+/* 3.4-compatibility */
+static gpointer setup_north_func(xmlNodePtr node);
+static gpointer setup_south_func(xmlNodePtr node);
+static gpointer setup_east_func(xmlNodePtr node);
+static gpointer setup_west_func(xmlNodePtr node);
 
-void action_growtoedge_startup()
+void action_growtoedge_startup(void)
 {
-    actions_register("GrowToEdge",
-                     setup_func,
-                     free_func,
-                     run_func,
-                     NULL, NULL);
+    actions_register("GrowToEdge", setup_grow_func,
+                     free_func, run_func);
+    actions_register("GrowToFill", setup_fill_func,
+                     free_func, run_func);
+    actions_register("ShrinkToEdge", setup_shrink_func,
+                     free_func, run_func);
+    /* 3.4-compatibility */
+    actions_register("GrowToEdgeNorth", setup_north_func, free_func, run_func);
+    actions_register("GrowToEdgeSouth", setup_south_func, free_func, run_func);
+    actions_register("GrowToEdgeEast", setup_east_func, free_func, run_func);
+    actions_register("GrowToEdgeWest", setup_west_func, free_func, run_func);
 }
 
-static gpointer setup_func(ObParseInst *i, xmlDocPtr doc, xmlNodePtr node)
+static gpointer setup_func(xmlNodePtr node)
 {
     xmlNodePtr n;
     Options *o;
 
-    o = g_new0(Options, 1);
+    o = g_slice_new0(Options);
     o->dir = OB_DIRECTION_NORTH;
 
-    if ((n = parse_find_node("direction", node))) {
-        gchar *s = parse_string(doc, n);
+    if ((n = obt_xml_find_node(node, "direction"))) {
+        gchar *s = obt_xml_node_string(n);
         if (!g_ascii_strcasecmp(s, "north") ||
             !g_ascii_strcasecmp(s, "up"))
             o->dir = OB_DIRECTION_NORTH;
@@ -50,37 +65,224 @@ static gpointer setup_func(ObParseInst *i, xmlDocPtr doc, xmlNodePtr node)
     return o;
 }
 
-static void free_func(gpointer options)
+static gpointer setup_grow_func(xmlNodePtr node)
 {
-    Options *o = options;
+    Options *o;
+
+    o = setup_func(node);
+    o->shrink = FALSE;
+    o->fill = FALSE;
+
+    return o;
+}
+
+static gpointer setup_fill_func(xmlNodePtr node)
+{
+    Options *o;
+
+    o = setup_func(node);
+    o->shrink = FALSE;
+    o->fill = TRUE;
+
+    return o;
+}
+
+static gpointer setup_shrink_func(xmlNodePtr node)
+{
+    Options *o;
 
-    g_free(o);
+    o = setup_func(node);
+    o->shrink = TRUE;
+    o->fill = FALSE;
+
+    return o;
+}
+
+static gboolean do_grow(ObActionsData *data, gint x, gint y, gint w, gint h)
+{
+    gint realw, realh, lw, lh;
+
+    realw = w;
+    realh = h;
+    client_try_configure(data->client, &x, &y, &realw, &realh,
+                         &lw, &lh, TRUE);
+    /* if it's going to be resized smaller than it intended, don't
+       move the window over */
+    if (x != data->client->area.x) x += w - realw;
+    if (y != data->client->area.y) y += h - realh;
+
+    if (x != data->client->area.x || y != data->client->area.y ||
+        realw != data->client->area.width ||
+        realh != data->client->area.height)
+    {
+        actions_client_move(data, TRUE);
+        client_move_resize(data->client, x, y, realw, realh);
+        actions_client_move(data, FALSE);
+        return TRUE;
+    }
+    return FALSE;
+}
+
+static void free_func(gpointer o)
+{
+    g_slice_free(Options, o);
 }
 
 /* Always return FALSE because its not interactive */
 static gboolean run_func(ObActionsData *data, gpointer options)
 {
     Options *o = options;
+    gint x, y, w, h;
 
-    if (data->client) {
-        gint x, y, w, h;
+    gint half;
+
+    if (!data->client)
+        return FALSE;
+    if (data->client->shaded) {
+        gboolean doing_verical_resize =
+            o->dir == OB_DIRECTION_NORTH ||
+            o->dir == OB_DIRECTION_SOUTH ||
+            o->fill;
+        if (doing_verical_resize)
+            return FALSE;
+    }
+
+    if (o->fill) {
+        if (o->shrink) {
+            /* We don't have any implementation of shrinking for the FillToGrow
+               action. */
+            return FALSE;
+        }
 
-        /* don't allow vertical resize if shaded */
-        if (o->dir != OB_DIRECTION_NORTH || o->dir != OB_DIRECTION_SOUTH ||
-            !data->client->shaded)
+        ObClientDirectionalResizeType grow = CLIENT_RESIZE_GROW_IF_NOT_ON_EDGE;
+
+        gint temp_x;
+        gint temp_y;
+        gint temp_w;
+        gint temp_h;
+
+        client_find_resize_directional(data->client,
+                                       OB_DIRECTION_NORTH,
+                                       grow,
+                                       &temp_x, &temp_y, &temp_w, &temp_h);
+        y = temp_y;
+        h = temp_h;
+
+        client_find_resize_directional(data->client,
+                                       OB_DIRECTION_SOUTH,
+                                       grow,
+                                       &temp_x, &temp_y, &temp_w, &temp_h);
+        h += temp_h - data->client->area.height;
+
+
+        client_find_resize_directional(data->client,
+                                       OB_DIRECTION_WEST,
+                                       grow,
+                                       &temp_x, &temp_y, &temp_w, &temp_h);
+        x = temp_x;
+        w = temp_w;
+
+        client_find_resize_directional(data->client,
+                                       OB_DIRECTION_EAST,
+                                       grow,
+                                       &temp_x, &temp_y, &temp_w, &temp_h);
+        w += temp_w - data->client->area.width;
+
+        /* When filling, we allow the window to move to an arbitrary x/y
+           position, since we'll be growing the other edge as well. */
+        if (x != data->client->area.x || y != data->client->area.y ||
+            w != data->client->area.width || h != data->client->area.height)
         {
-            client_find_resize_directional(data->client, o->dir, TRUE,
-                                           &x, &y, &w, &h);
-            if (x != data->client->area.x || y != data->client->area.y ||
-                w != data->client->area.width ||
-                h != data->client->area.height)
-            {
-                actions_client_move(data, FALSE);
-                client_move_resize(data->client, x, y, w, h);
-                actions_client_move(data, TRUE);
-            }
+            actions_client_move(data, TRUE);
+            client_move_resize(data->client, x, y, w, h);
+            actions_client_move(data, FALSE);
+        }
+        return FALSE;
+    }
+
+    if (!o->shrink) {
+        /* Try grow. */
+        client_find_resize_directional(data->client,
+                                       o->dir,
+                                       CLIENT_RESIZE_GROW,
+                                       &x, &y, &w, &h);
+
+        if (do_grow(data, x, y, w, h))
+            return FALSE;
+    }
+
+    /* We couldn't grow, so try shrink! */
+    ObDirection opposite =
+        (o->dir == OB_DIRECTION_NORTH ? OB_DIRECTION_SOUTH :
+         (o->dir == OB_DIRECTION_SOUTH ? OB_DIRECTION_NORTH :
+          (o->dir == OB_DIRECTION_EAST ? OB_DIRECTION_WEST :
+           OB_DIRECTION_EAST)));
+    client_find_resize_directional(data->client,
+                                   opposite,
+                                   CLIENT_RESIZE_SHRINK,
+                                   &x, &y, &w, &h);
+    switch (opposite) {
+    case OB_DIRECTION_NORTH:
+        half = data->client->area.y + data->client->area.height / 2;
+        if (y > half) {
+            h += y - half;
+            y = half;
+        }
+        break;
+    case OB_DIRECTION_SOUTH:
+        half = data->client->area.height / 2;
+        if (h < half)
+            h = half;
+        break;
+    case OB_DIRECTION_WEST:
+        half = data->client->area.x + data->client->area.width / 2;
+        if (x > half) {
+            w += x - half;
+            x = half;
         }
+        break;
+    case OB_DIRECTION_EAST:
+        half = data->client->area.width / 2;
+        if (w < half)
+            w = half;
+        break;
+    default: g_assert_not_reached();
     }
+    if (do_grow(data, x, y, w, h))
+        return FALSE;
 
     return FALSE;
 }
+
+/* 3.4-compatibility */
+static gpointer setup_north_func(xmlNodePtr node)
+{
+    Options *o = g_slice_new0(Options);
+    o->shrink = FALSE;
+    o->dir = OB_DIRECTION_NORTH;
+    return o;
+}
+
+static gpointer setup_south_func(xmlNodePtr node)
+{
+    Options *o = g_slice_new0(Options);
+    o->shrink = FALSE;
+    o->dir = OB_DIRECTION_SOUTH;
+    return o;
+}
+
+static gpointer setup_east_func(xmlNodePtr node)
+{
+    Options *o = g_slice_new0(Options);
+    o->shrink = FALSE;
+    o->dir = OB_DIRECTION_EAST;
+    return o;
+}
+
+static gpointer setup_west_func(xmlNodePtr node)
+{
+    Options *o = g_slice_new0(Options);
+    o->shrink = FALSE;
+    o->dir = OB_DIRECTION_WEST;
+    return o;
+}