X-Git-Url: http://git.openbox.org/?p=dana%2Fopenbox.git;a=blobdiff_plain;f=HACKING;h=e450bba39e8f5a0a3b351b1e09bf1197c1d8e914;hp=56cca150e129df3fe5ed8d8df8bd581df856884d;hb=1ffc0021325e30db7bb7f8b2a17ca7f5546b3324;hpb=d963ae89a3cbae13de7c28a0564880ac3422a5a8 diff --git a/HACKING b/HACKING index 56cca15..e450bba 100644 --- a/HACKING +++ b/HACKING @@ -1,10 +1,13 @@ -Woop, a HACKING document for openbox at last! +dirs: + openbox - core of the WM + render - librender, rendering routines for the WM and for apps + parser - libparser, for parsing config files Beware the Client.transient_for. It can be set to a !NULL value of TRAN_GROUP, which is not a valid pointer. You must ALWAYS check for TRAN_GROUP before -following transient_for. When TRAN_GROUP is found, Client.group will always -be !NULL. Some smart action should be taken using all members of the group in -this case. +following transient_for. However if it is transient for the group, this +excludes other windows whom are transient for the group, and windows which +are children of the window (infinite loops would result)! When using coordinates/sizes of windows, make sure you use the right area. The Client.area rect is the reference point and size of the *CLIENT* window. This @@ -13,3 +16,18 @@ translate it into what you see. The Client.frame.area is the actual position and size of the entire frame. This is usually the value you want to use, unless you are in client.c (probably) and adjusting/using the position or size from the client's perspective. + +Indentation +----------- +For openbox, we aim to have consistent coding style. Some, but surely +not all, guidelines: + * use 4 space indents + * tabs should not appear in source files + * functions should have the opening and closing braces on their own + lines + * most other constructs should have braces on the same line as the + statement + * else appears on a new line, just like an if + * when in doubt look at the rest of the source + * vim users can use "set expandtab tabstop=4 shiftwidth=4 + softtabstop=4" for some of this