projects
/
dana
/
openbox.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
3961980
)
Fix an if statement getting moved into a loop it shouldn't have
author
Mikael Magnusson
<mikachu@gmail.com>
Tue, 28 Oct 2014 03:34:21 +0000
(
04:34
+0100)
committer
Mikael Magnusson
<mikachu@gmail.com>
Tue, 28 Oct 2014 03:34:21 +0000
(
04:34
+0100)
Found by coverity code analysis.
openbox/place.c
patch
|
blob
|
history
diff --git
a/openbox/place.c
b/openbox/place.c
index
aa3ff63
..
de2c7dc
100644
(file)
--- a/
openbox/place.c
+++ b/
openbox/place.c
@@
-360,11
+360,11
@@
static gboolean place_transient_splash(ObClient *client, Rect *area,
b = MAX(b, RECT_BOTTOM(m->frame->area));
}
}
- if (!first) {
- *x = ((r + 1 - l) - frame_size.width) / 2 + l;
-
*y = ((b + 1 - t) - frame_size.height) / 2 + t
;
-
return TRUE
;
- }
+ }
+ if (!first) {
+
*x = ((r + 1 - l) - frame_size.width) / 2 + l
;
+
*y = ((b + 1 - t) - frame_size.height) / 2 + t
;
+ return TRUE;
}
}