More menu changes to facilitate plugins.

diff --git a/openbox/menu.c b/openbox/menu.c
index 314c2f5..42a183a 100644 (file)
--- a/openbox/menu.c
+++ b/openbox/menu.c
@@ -12,6 +12,8 @@ GHashTable *menu_map = NULL;
 #define ENTRY_EVENTMASK (EnterWindowMask | LeaveWindowMask | \
                          ButtonPressMask | ButtonReleaseMask)
 
+void menu_control_show(Menu *self, int x, int y, Client *client);
+
 void menu_destroy_hash_key(gpointer data)
 {
     g_free(data);
@@ -91,7 +93,8 @@ static Window createWindow(Window parent, unsigned long mask,
                        
 }
 
-Menu *menu_new(char *label, char *name, Menu *parent)
+Menu *menu_new_full(char *label, char *name, Menu *parent, 
+                    menu_controller_show show, menu_controller_update update)
 {
     XSetWindowAttributes attrib;
     Menu *self;
@@ -105,6 +108,12 @@ Menu *menu_new(char *label, char *name, Menu *parent)
     self->shown = FALSE;
     self->invalid = FALSE;
     /* default controllers? */
+    
+    self->show = show;
+    self->hide = NULL;
+    self->update = update;
+    self->mouseover = NULL;
+    self->selected = NULL;
 
     attrib.override_redirect = TRUE;
     attrib.event_mask = FRAME_EVENTMASK;
@@ -195,20 +204,21 @@ void menu_show(char *name, int x, int y, Client *client)
                   name);
         return;
     }
-    
-    if(self->invalid) {
-      menu_render(self);
-    }
-
-    XMoveWindow(ob_display, self->frame, x, y);
 
+    if (self->invalid) {
+      if (self->update) {
+        self->update(self);
+      } else {
+        menu_render(self);
+      }
+    }
+    
     self->client = client;
 
-    if (!self->shown) {
-        stacking_raise_internal(self->frame);
-        XMapWindow(ob_display, self->frame);
-/*        grab_pointer_window(TRUE, None, self->frame);*/
-        self->shown = TRUE;
+    if (self->show) {
+      self->show(self, x, y, client);
+    } else {
+      menu_control_show(self, x, y, client);
     }
 }
 
@@ -268,3 +278,17 @@ void menu_entry_fire(MenuEntry *self)
         menu_hide(m);
     }
 }
+
+/* 
+   Default menu controller action for showing.
+*/
+
+void menu_control_show(Menu *self, int x, int y, Client *client) {
+  XMoveWindow(ob_display, self->frame, x, y);
+
+  if (!self->shown) {
+    stacking_raise_internal(self->frame);
+    XMapWindow(ob_display, self->frame);
+    self->shown = TRUE;
+  }
+}

diff --git a/openbox/menu.h b/openbox/menu.h
index 1c1b31d..1a3f002 100644 (file)
--- a/openbox/menu.h
+++ b/openbox/menu.h
@@ -8,23 +8,28 @@
 
 extern GHashTable *menu_map;
 
+struct Menu;
+
+typedef void(*menu_controller_show)(struct Menu *self, int x, int y, Client *);
+typedef void(*menu_controller_update)(struct Menu *self);
+
 typedef struct Menu {
     char *label;
     char *name;
     
     GList *entries;
-    /* GList *tail; */
 
-    /* ? */
     gboolean shown;
     gboolean invalid;
 
     struct Menu *parent;
 
-    /* waste o' pointers */
-    void (*show)( /* some bummu */);
+    /* place a menu on screen */
+    menu_controller_show show;
     void (*hide)( /* some bummu */);
-    void (*update)( /* some bummu */);
+
+    /* render a menu */
+    menu_controller_update update;
     void (*mouseover)( /* some bummu */);
     void (*selected)( /* some bummu */);
 
@@ -76,7 +81,11 @@ typedef struct {
 void menu_startup();
 void menu_shutdown();
 
-Menu *menu_new(char *label, char *name, Menu *parent);
+#define menu_new(l, n, p) \
+  menu_new_full(l, n, p, NULL, NULL)
+
+Menu *menu_new_full(char *label, char *name, Menu *parent, 
+                    menu_controller_show show, menu_controller_update update);
 void menu_free(char *name);
 
 void menu_show(char *name, int x, int y, Client *client);

diff --git a/openbox/menu_render.c b/openbox/menu_render.c
index 1e57d12..cf961f2 100644 (file)
--- a/openbox/menu_render.c
+++ b/openbox/menu_render.c
@@ -1,4 +1,4 @@
-// Functions for default rendering of menus. Might become pluginnable
+/* Functions for default rendering of menus. Might become pluginnable */
 
 #include "menu.h"
 #include "openbox.h"