From 26951b0d4c90fa04b94561c9ff717dc700ba482b Mon Sep 17 00:00:00 2001 From: Edward Sheldrake Date: Tue, 28 Oct 2014 01:28:35 +0100 Subject: [PATCH] Fix use after free in menu_entry_frame_free --- openbox/menuframe.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/openbox/menuframe.c b/openbox/menuframe.c index c390c07..7868df3 100644 --- a/openbox/menuframe.c +++ b/openbox/menuframe.c @@ -203,8 +203,6 @@ static ObMenuEntryFrame* menu_entry_frame_new(ObMenuEntry *entry, static void menu_entry_frame_free(ObMenuEntryFrame *self) { if (self) { - menu_entry_unref(self->entry); - window_remove(self->window); XDestroyWindow(obt_display, self->text); @@ -221,6 +219,7 @@ static void menu_entry_frame_free(ObMenuEntryFrame *self) g_hash_table_remove(menu_frame_map, &self->bullet); } + menu_entry_unref(self->entry); g_slice_free(ObMenuEntryFrame, self); } } -- 1.9.1