it would seem this cannot return NULL now

It will get the primary monitor if there is not monitor under the pointer. But
assert so it's clear something went wrong if this does happen. Note that there
was previously no check for the return value even though the comment claimed
there should be.

diff --git a/openbox/place.c b/openbox/place.c
index d56adfc..a13bc2c 100644 (file)
--- a/openbox/place.c
+++ b/openbox/place.c
@@ -451,9 +451,10 @@ static gboolean place_per_app_setting(ObClient *client, gint *x, gint *y,
     ob_debug("placing by per-app settings");
 
     /* Find which head the pointer is on */
     ob_debug("placing by per-app settings");
 
     /* Find which head the pointer is on */

-    if (settings->monitor == 0)
-        /* this can return NULL */
+    if (settings->monitor == 0) {

         screen = pick_pointer_head(client);
         screen = pick_pointer_head(client);

+        g_assert(screen);
+    }

     else {
         guint m = settings->monitor;
         if (m < 1 || m > screen_num_monitors)
     else {
         guint m = settings->monitor;
         if (m < 1 || m > screen_num_monitors)