From: Mikael Magnusson <mikachu@gmail.com>
Date: Tue, 28 Oct 2014 03:34:21 +0000 (+0100)
Subject: Fix an if statement getting moved into a loop it shouldn't have
X-Git-Tag: release-3.6.0~26
X-Git-Url: http://git.openbox.org/?p=mikachu%2Fopenbox.git;a=commitdiff_plain;h=1387b33394a219e0a64015d614fc9a44e611901b

Fix an if statement getting moved into a loop it shouldn't have

Found by coverity code analysis.
---

diff --git a/openbox/place.c b/openbox/place.c
index aa3ff63..de2c7dc 100644
--- a/openbox/place.c
+++ b/openbox/place.c
@@ -360,11 +360,11 @@ static gboolean place_transient_splash(ObClient *client, Rect *area,
                     b = MAX(b, RECT_BOTTOM(m->frame->area));
                 }
             }
-            if (!first) {
-                *x = ((r + 1 - l) - frame_size.width) / 2 + l;
-                *y = ((b + 1 - t) - frame_size.height) / 2 + t;
-                return TRUE;
-            }
+        }
+        if (!first) {
+            *x = ((r + 1 - l) - frame_size.width) / 2 + l;
+            *y = ((b + 1 - t) - frame_size.height) / 2 + t;
+            return TRUE;
         }
     }