From: Mikael Magnusson <mikachu@gmail.com>
Date: Tue, 28 Oct 2014 02:44:28 +0000 (+0100)
Subject: Use PANGO_UNDERLINE_SINGLE for rendering shortcuts
X-Git-Tag: release-3.6.0~27
X-Git-Url: http://git.openbox.org/?p=mikachu%2Fopenbox.git;a=commitdiff_plain;h=396198081e72d6d758d51d4c6cdda1105be0df2d;ds=sidebyside

Use PANGO_UNDERLINE_SINGLE for rendering shortcuts

The pango docs say to use _LOW for accelerators, but that causes the line
to be drawn beneath the ink extents which for us may be outside the area
that gets displayed and we end up with no line at all. We also don't want
to extend every menu entry with enough space to fit this possible line.
---

diff --git a/obrender/font.c b/obrender/font.c
index a22e23f..0f56a55 100644
--- a/obrender/font.c
+++ b/obrender/font.c
@@ -73,7 +73,7 @@ RrFont *RrFontOpen(const RrInstance *inst, const gchar *name, gint size,
     out->ref = 1;
     out->font_desc = pango_font_description_new();
     out->layout = pango_layout_new(inst->pango);
-    out->shortcut_underline = pango_attr_underline_new(PANGO_UNDERLINE_LOW);
+    out->shortcut_underline = pango_attr_underline_new(PANGO_UNDERLINE_SINGLE);
     out->shortcut_underline->start_index = 0;
     out->shortcut_underline->end_index = 0;