From 1387b33394a219e0a64015d614fc9a44e611901b Mon Sep 17 00:00:00 2001 From: Mikael Magnusson Date: Tue, 28 Oct 2014 04:34:21 +0100 Subject: [PATCH 1/1] Fix an if statement getting moved into a loop it shouldn't have Found by coverity code analysis. --- openbox/place.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/openbox/place.c b/openbox/place.c index aa3ff63..de2c7dc 100644 --- a/openbox/place.c +++ b/openbox/place.c @@ -360,11 +360,11 @@ static gboolean place_transient_splash(ObClient *client, Rect *area, b = MAX(b, RECT_BOTTOM(m->frame->area)); } } - if (!first) { - *x = ((r + 1 - l) - frame_size.width) / 2 + l; - *y = ((b + 1 - t) - frame_size.height) / 2 + t; - return TRUE; - } + } + if (!first) { + *x = ((r + 1 - l) - frame_size.width) / 2 + l; + *y = ((b + 1 - t) - frame_size.height) / 2 + t; + return TRUE; } } -- 1.9.1