From: Federico Mena Quintero <federico@novell.com>
Date: Wed, 9 Apr 2008 20:20:19 +0000 (+0000)
Subject: Don't leak apps_by_name in GBookmarkFile metadata items
X-Git-Url: http://git.openbox.org/?a=commitdiff_plain;h=0c153b46e2434780bf68ceda47e1f3d8a7db6ded;p=dana%2Fcg-glib.git

Don't leak apps_by_name in GBookmarkFile metadata items
2008-04-09  Federico Mena Quintero  <federico@novell.com>

	* glib/gbookmarkfile.c (bookmark_metadata_free): Don't leak
	the apps_by_name hash table if the applications list is empty.

Signed-off-by: Federico Mena Quintero <federico@gnu.org>

svn path=/trunk/; revision=6846
---

diff --git a/ChangeLog b/ChangeLog
index 2028a348..72ad4b38 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2008-04-09  Federico Mena Quintero  <federico@novell.com>
+
+	* glib/gbookmarkfile.c (bookmark_metadata_free): Don't leak
+	the apps_by_name hash table if the applications list is empty.
+
 2008-04-08  Behdad Esfahbod  <behdad@gnome.org>
 
 	* glib/gunicode.h: Add ISO 15924 code comments for new scripts.
diff --git a/glib/gbookmarkfile.c b/glib/gbookmarkfile.c
index 70ce6ee5..7c34312c 100644
--- a/glib/gbookmarkfile.c
+++ b/glib/gbookmarkfile.c
@@ -325,10 +325,10 @@ bookmark_metadata_free (BookmarkMetadata *metadata)
 		      (GFunc) bookmark_app_info_free,
 		      NULL);
       g_list_free (metadata->applications);
-      
-      g_hash_table_destroy (metadata->apps_by_name);
     }
-  
+
+  g_hash_table_destroy (metadata->apps_by_name);
+
   g_free (metadata->icon_href);
   g_free (metadata->icon_mime);