From: root <root>
Date: Thu, 19 Jan 2006 16:07:09 +0000 (+0000)
Subject: *** empty log message ***
X-Git-Url: http://git.openbox.org/?a=commitdiff_plain;h=4e7cf7ad83b7236515d54afd2d4f6531d418756a;p=dana%2Furxvt.git

*** empty log message ***
---

diff --git a/Changes b/Changes
index 989d065c..035a88cd 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,7 @@
 rxvt-unicode changelog <= google-friendly title
 
+TODO: event mechanism that replaces on_keyboard_command with something more scalable.
+TODO: simplify selection_request and make it callable from perl.
 TODO: split perl documnetation and urxvt.pm into separate files
 TODO: nuke rxvt_privaction and related garbage
 TODO: harmonize --disable-options into position-dependent options.
@@ -8,13 +10,13 @@ TODO: "slow" rendering mode for bidi and scripts
 TODO: read property sequence is broken with respect to utf-8 etc.
 TODO: http://www120.pair.com/mccarthy/nextstep/intro.htmld/Workspace.html is the correct nextstep look.
 TODO: rxvt -name urxvt-girly /// leave pixel droppings
+TODO: distributed clipboard example
 WISH: perl extension for background image loading and moving the origin.
 WISH: OnTheSpot editing, or maybe switch to miiiiiiif. or maybe use perl and an overlay...
 WISH: just for fun, do shade and tint with XRender.
 WISH: support tex fonts
 
 9.0
-TODO: distributed clipboard example
         - setuid/setgid operation is now _encouraged_: security has been
           improved by moving privileged operations into a separate process
           and permanently dropping privileges within the terminal. This
diff --git a/src/perl/selection-pastebin b/src/perl/selection-pastebin
index 637328a5..fa34b73c 100644
--- a/src/perl/selection-pastebin
+++ b/src/perl/selection-pastebin
@@ -55,13 +55,13 @@ sub on_start {
    $pastebin_url = $self->x_resource ("selection-pastebin.url")
                    || "http://www.ta-sa.org/files/txt/%";
 
-   push @urxvt::ext::selection_popup::hook, sub {
-      ("pastebin upload" => sub { $self->upload_paste })
-   };
-
    ()
 }
 
+push @urxvt::ext::selection_popup::hook, sub {
+   ("pastebin upload" => sub { $self->upload_paste })
+};
+
 sub on_keyboard_command {
    my ($self, $cmd) = @_;
 
diff --git a/src/urxvt.pm b/src/urxvt.pm
index 6b403c50..bdbf6ca4 100644
--- a/src/urxvt.pm
+++ b/src/urxvt.pm
@@ -109,6 +109,9 @@ C<a>s:
           : ()
    };
 
+Don't run it in a hook, otherwise the menu will grow and grow. Instead put
+it at the toplevel of your extension.
+
 =item searchable-scrollback<hotkey> (enabled by default)
 
 Adds regex search functionality to the scrollback buffer, triggered