From: Dana Jansens <danakj@orodu.net>
Date: Fri, 25 Jun 2010 17:43:21 +0000 (+0200)
Subject: unredirect on a window with bad timing can cause a BadValue error
X-Git-Tag: cgl~17
X-Git-Url: http://git.openbox.org/?a=commitdiff_plain;h=ad8329f0904040a028918c936e50778588a8089d;p=dana%2Fopenbox.git

unredirect on a window with bad timing can cause a BadValue error

exemplified by right clicking on wbar a lot causing it to remap itself
---

diff --git a/openbox/composite.c b/openbox/composite.c
index ea8fbcae..6e52ead0 100644
--- a/openbox/composite.c
+++ b/openbox/composite.c
@@ -649,8 +649,11 @@ static void composite_window_unredir(ObWindow *w)
 {
     if (!w->redir) return;
 
+    /* this call can cause a BadValue error */
+    obt_display_ignore_errors(TRUE);
     XCompositeUnredirectWindow(obt_display, window_redir(w),
                                CompositeRedirectManual);
+    obt_display_ignore_errors(FALSE);
     w->is_redir = FALSE;
 }