From: Dana Jansens <danakj@orodu.net>
Date: Wed, 20 Nov 2002 05:22:38 +0000 (+0000)
Subject: fix menu redraw bug for real
X-Git-Tag: openbox-2_1_3^2~12
X-Git-Url: http://git.openbox.org/?a=commitdiff_plain;h=bace14f74970258b80c0c7615fcd3b99a2324fcc;p=dana%2Fopenbox.git

fix menu redraw bug for real
---

diff --git a/CHANGELOG b/CHANGELOG
index 9c393f46..daa557cb 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -14,8 +14,8 @@ Changelog for Openbox:
    don't work at all for high-ascii letters, which are
    used in the non-english locales.
 
- * Fix menu redraw bug when dragging them off-screen or (Scott Moynes)
-   under other menus, with Xft fonts.
+ * Fix menu redraw bug when dragging them off-screen or (Scott Moynes,
+   under other menus, with Xft fonts.                    Ben Jansens)
 
  * Build fixes for xftlsfonts and for openbox on        (Marius Nita)
    redhat systems.
diff --git a/src/Basemenu.cc b/src/Basemenu.cc
index 3c096eff..02bd6435 100644
--- a/src/Basemenu.cc
+++ b/src/Basemenu.cc
@@ -611,11 +611,6 @@ void Basemenu::drawItem(int index, bool highlight, bool clear,
       dooppsel = False;
   }
 
-#ifdef    XFT
-  if (dotext)
-    XClearArea(display, menu.frame, text_x, text_y , text_w, text_h, False);
-#endif // XFT
-
   if (dohilite && highlight && (menu.hilite_pixmap != ParentRelative)) {
     if (menu.hilite_pixmap)
       XCopyArea(display, menu.hilite_pixmap, menu.frame,
@@ -945,8 +940,12 @@ void Basemenu::exposeEvent(XExposeEvent *ee) {
       for (int ii = id; ii <= id_d && it != end; ++it, ii++) {
         const int index = ii + (i * menu.persub);
         // redraw the item
-        drawItem(index, (which_sub == index), False,
-                 ee->x, ee->y, ee->width, ee->height);
+        drawItem(index, (which_sub == index),
+#ifdef XFT
+                 True);
+#else
+                 False, ee->x, ee->y, ee->width, ee->height);
+#endif // XFT
       }
     }
   }