From: Tor Lillqvist <tml@iki.fi>
Date: Mon, 6 Dec 2004 23:43:43 +0000 (+0000)
Subject: Fix a write to freed memory: Unlock the channel's mutex before unrefing
X-Git-Url: http://git.openbox.org/?a=commitdiff_plain;h=cf6e3acdb56b846fceb92ccfb2f201c4c6d4ff5f;p=dana%2Fcg-glib.git

Fix a write to freed memory: Unlock the channel's mutex before unrefing

2004-12-06  Tor Lillqvist  <tml@iki.fi>

	* glib/giowin32.c (g_io_win32_finalize): Fix a write to freed
	memory: Unlock the channel's mutex before unrefing the channel.
---

diff --git a/ChangeLog b/ChangeLog
index 72e7dfdd..59ab5ae0 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2004-12-06  Tor Lillqvist  <tml@iki.fi>
+
+	* glib/giowin32.c (g_io_win32_finalize): Fix a write to freed
+	memory: Unlock the channel's mutex before unrefing the channel.
+
 2004-12-06  Matthias Clasen  <mclasen@redhat.com>
 
 	* configure.in: Remove a no longer needed hack for 
diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index 72e7dfdd..59ab5ae0 100644
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,8 @@
+2004-12-06  Tor Lillqvist  <tml@iki.fi>
+
+	* glib/giowin32.c (g_io_win32_finalize): Fix a write to freed
+	memory: Unlock the channel's mutex before unrefing the channel.
+
 2004-12-06  Matthias Clasen  <mclasen@redhat.com>
 
 	* configure.in: Remove a no longer needed hack for 
diff --git a/ChangeLog.pre-2-12 b/ChangeLog.pre-2-12
index 72e7dfdd..59ab5ae0 100644
--- a/ChangeLog.pre-2-12
+++ b/ChangeLog.pre-2-12
@@ -1,3 +1,8 @@
+2004-12-06  Tor Lillqvist  <tml@iki.fi>
+
+	* glib/giowin32.c (g_io_win32_finalize): Fix a write to freed
+	memory: Unlock the channel's mutex before unrefing the channel.
+
 2004-12-06  Matthias Clasen  <mclasen@redhat.com>
 
 	* configure.in: Remove a no longer needed hack for 
diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6
index 72e7dfdd..59ab5ae0 100644
--- a/ChangeLog.pre-2-6
+++ b/ChangeLog.pre-2-6
@@ -1,3 +1,8 @@
+2004-12-06  Tor Lillqvist  <tml@iki.fi>
+
+	* glib/giowin32.c (g_io_win32_finalize): Fix a write to freed
+	memory: Unlock the channel's mutex before unrefing the channel.
+
 2004-12-06  Matthias Clasen  <mclasen@redhat.com>
 
 	* configure.in: Remove a no longer needed hack for 
diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8
index 72e7dfdd..59ab5ae0 100644
--- a/ChangeLog.pre-2-8
+++ b/ChangeLog.pre-2-8
@@ -1,3 +1,8 @@
+2004-12-06  Tor Lillqvist  <tml@iki.fi>
+
+	* glib/giowin32.c (g_io_win32_finalize): Fix a write to freed
+	memory: Unlock the channel's mutex before unrefing the channel.
+
 2004-12-06  Matthias Clasen  <mclasen@redhat.com>
 
 	* configure.in: Remove a no longer needed hack for 
diff --git a/glib/giowin32.c b/glib/giowin32.c
index 9bffc057..72fe44e6 100644
--- a/glib/giowin32.c
+++ b/glib/giowin32.c
@@ -737,8 +737,8 @@ g_io_win32_finalize (GSource *source)
     send (channel->reset_send, send_buffer, sizeof (send_buffer), 0);
   }
 
-  g_io_channel_unref (watch->channel);
   UNLOCK (channel->mutex);
+  g_io_channel_unref (watch->channel);
 }
 
 GSourceFuncs g_io_watch_funcs = {