From 0c70e10576786b3107ade29935bd818cede51d47 Mon Sep 17 00:00:00 2001
From: ayin <ayin>
Date: Sun, 17 Feb 2008 12:11:56 +0000
Subject: [PATCH] Make scrollbar_{minheight,size} methods of scrollBar_t.

---
 src/command.C   |  6 +++---
 src/scrollbar.C |  8 ++++----
 src/scrollbar.h | 16 ++++++++--------
 3 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/src/command.C b/src/command.C
index 58e5acf8..0b7667de 100644
--- a/src/command.C
+++ b/src/command.C
@@ -1647,7 +1647,7 @@ rxvt_term::x_cb (XEvent &ev)
                           &ev.xbutton.x, &ev.xbutton.y,
                           &unused_mask);
             scr_move_to (scrollbar_position (ev.xbutton.y) - csrO,
-                         scrollbar_size ());
+                         scrollBar.size ());
             want_refresh = 1;
             scrollbar_show (1);
           }
@@ -2012,7 +2012,7 @@ rxvt_term::button_press (XButtonEvent &ev)
                   if (scrollBar.style == R_SB_XTERM
                       || scrollbar_above_slider (ev.y)
                       || scrollbar_below_slider (ev.y))
-                    scr_move_to (scrollbar_position (ev.y) - csrO, scrollbar_size ());
+                    scr_move_to (scrollbar_position (ev.y) - csrO, scrollBar.size ());
 
                   scrollBar.state = STATE_MOTION;
                   break;
@@ -2045,7 +2045,7 @@ rxvt_term::button_press (XButtonEvent &ev)
                       scr_page ((ev.button == Button1 ? DN : UP),
                                 (nrow
                                  * scrollbar_position (ev.y)
-                                 / scrollbar_size ()));
+                                 / scrollBar.size ()));
                     }
 
                   break;
diff --git a/src/scrollbar.C b/src/scrollbar.C
index 514ce498..ef9fa555 100644
--- a/src/scrollbar.C
+++ b/src/scrollbar.C
@@ -151,11 +151,11 @@ rxvt_term::scrollbar_show (int update)
       top = view_start - top_row;
       bot = top + (nrow - 1);
       len = max (nrow - 1 - top_row, 1);
-      adj = (((bot - top) * scrollbar_size ()) % len) > 0 ? 1 : 0;
+      adj = (((bot - top) * scrollBar.size ()) % len) > 0 ? 1 : 0;
 
-      scrollBar.top = (scrollBar.beg + (top * scrollbar_size ()) / len);
-      scrollBar.len = ((bot - top) * scrollbar_size ()) / len +
-                      scrollbar_minheight () + adj;
+      scrollBar.top = (scrollBar.beg + (top * scrollBar.size ()) / len);
+      scrollBar.len = ((bot - top) * scrollBar.size ()) / len +
+                      scrollBar.min_height () + adj;
       scrollBar.bot = (scrollBar.top + scrollBar.len);
       /* no change */
       if (scrollBar.top == scrollBar.last_top
diff --git a/src/scrollbar.h b/src/scrollbar.h
index acf19003..3697da08 100644
--- a/src/scrollbar.h
+++ b/src/scrollbar.h
@@ -83,23 +83,23 @@ struct scrollBar_t {
       return y > end;
     return false;
   }
+  unsigned min_height ()
+  {
+    return style == R_SB_NEXT ? SB_THUMB_MIN_HEIGHT : 10;
+  }
+  unsigned size ()
+  {
+    return end - beg - min_height ();
+  }
   unsigned total_width ()
   {
     return width + shadow * 2;
   }
 };
 
-#define SCROLLNEXT_MINHEIGHT    SB_THUMB_MIN_HEIGHT
-#define SCROLLRXVT_MINHEIGHT    10
-
-#define scrollbar_minheight()   (scrollBar.style == R_SB_NEXT        \
-                                 ? SCROLLNEXT_MINHEIGHT                 \
-                                 : SCROLLRXVT_MINHEIGHT)
 #define scrollbar_above_slider(y)       ((y) < scrollBar.top)
 #define scrollbar_below_slider(y)       ((y) > scrollBar.bot)
 #define scrollbar_position(y)           ((y) - scrollBar.beg)
-#define scrollbar_size()                (scrollBar.end - scrollBar.beg \
-                                         - scrollbar_minheight ())
 
  /*
   *    +-------------+
-- 
2.34.1