From 263a48aaec3a1d59c0da2599a49787aec3b5b921 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Thu, 8 Nov 2007 05:24:29 +0000 Subject: [PATCH] Don't leave out parameters uninitialized. (#490061, Benjamin Otte) 2007-11-08 Matthias Clasen * glib/gstrfuncs.c (g_parse_long_long): Don't leave out parameters uninitialized. (#490061, Benjamin Otte) svn path=/trunk/; revision=5819 --- ChangeLog | 5 +++++ glib/gstrfuncs.c | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 382365f7..11e035e9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2007-11-08 Matthias Clasen + + * glib/gstrfuncs.c (g_parse_long_long): Don't leave + out parameters uninitialized. (#490061, Benjamin Otte) + 2007-11-07 Matthias Clasen * glib/gmain.c (g_main_context_unref): Don't leak the diff --git a/glib/gstrfuncs.c b/glib/gstrfuncs.c index c75daad6..713df3e4 100644 --- a/glib/gstrfuncs.c +++ b/glib/gstrfuncs.c @@ -650,9 +650,12 @@ g_parse_long_long (const gchar *nptr, g_return_val_if_fail (nptr != NULL, 0); + *negative = FALSE; if (base == 1 || base > 36) { errno = EINVAL; + if (endptr) + *endptr = nptr; return 0; } @@ -666,7 +669,6 @@ g_parse_long_long (const gchar *nptr, goto noconv; /* Check for a sign. */ - *negative = FALSE; if (*s == '-') { *negative = TRUE; -- 2.34.1