From 4a298b0fc6ee5d77656e8c016cff04f280b95a3c Mon Sep 17 00:00:00 2001 From: Havoc Pennington Date: Fri, 14 Dec 2001 16:26:24 +0000 Subject: [PATCH] note on how to free returned vector 2001-12-14 Havoc Pennington * glib/gshell.c (g_shell_parse_argv): note on how to free returned vector 2001-12-08 Havoc Pennington * glib/gspawn.c (fork_exec_with_pipes): include argv[0] in error message about failure to exec --- ChangeLog | 10 ++++++++++ ChangeLog.pre-2-0 | 10 ++++++++++ ChangeLog.pre-2-10 | 10 ++++++++++ ChangeLog.pre-2-12 | 10 ++++++++++ ChangeLog.pre-2-2 | 10 ++++++++++ ChangeLog.pre-2-4 | 10 ++++++++++ ChangeLog.pre-2-6 | 10 ++++++++++ ChangeLog.pre-2-8 | 10 ++++++++++ glib/gshell.c | 2 +- glib/gspawn.c | 6 ++++-- 10 files changed, 85 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 2c5b889d..80fbeb37 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,13 @@ +2001-12-14 Havoc Pennington + + * glib/gshell.c (g_shell_parse_argv): note on how to free returned + vector + +2001-12-08 Havoc Pennington + + * glib/gspawn.c (fork_exec_with_pipes): include argv[0] in error + message about failure to exec + 2001-12-13 Matthias Clasen * glib/gconvert.c, glib/giochannel.c, glib/gmain.c, diff --git a/ChangeLog.pre-2-0 b/ChangeLog.pre-2-0 index 2c5b889d..80fbeb37 100644 --- a/ChangeLog.pre-2-0 +++ b/ChangeLog.pre-2-0 @@ -1,3 +1,13 @@ +2001-12-14 Havoc Pennington + + * glib/gshell.c (g_shell_parse_argv): note on how to free returned + vector + +2001-12-08 Havoc Pennington + + * glib/gspawn.c (fork_exec_with_pipes): include argv[0] in error + message about failure to exec + 2001-12-13 Matthias Clasen * glib/gconvert.c, glib/giochannel.c, glib/gmain.c, diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index 2c5b889d..80fbeb37 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,3 +1,13 @@ +2001-12-14 Havoc Pennington + + * glib/gshell.c (g_shell_parse_argv): note on how to free returned + vector + +2001-12-08 Havoc Pennington + + * glib/gspawn.c (fork_exec_with_pipes): include argv[0] in error + message about failure to exec + 2001-12-13 Matthias Clasen * glib/gconvert.c, glib/giochannel.c, glib/gmain.c, diff --git a/ChangeLog.pre-2-12 b/ChangeLog.pre-2-12 index 2c5b889d..80fbeb37 100644 --- a/ChangeLog.pre-2-12 +++ b/ChangeLog.pre-2-12 @@ -1,3 +1,13 @@ +2001-12-14 Havoc Pennington + + * glib/gshell.c (g_shell_parse_argv): note on how to free returned + vector + +2001-12-08 Havoc Pennington + + * glib/gspawn.c (fork_exec_with_pipes): include argv[0] in error + message about failure to exec + 2001-12-13 Matthias Clasen * glib/gconvert.c, glib/giochannel.c, glib/gmain.c, diff --git a/ChangeLog.pre-2-2 b/ChangeLog.pre-2-2 index 2c5b889d..80fbeb37 100644 --- a/ChangeLog.pre-2-2 +++ b/ChangeLog.pre-2-2 @@ -1,3 +1,13 @@ +2001-12-14 Havoc Pennington + + * glib/gshell.c (g_shell_parse_argv): note on how to free returned + vector + +2001-12-08 Havoc Pennington + + * glib/gspawn.c (fork_exec_with_pipes): include argv[0] in error + message about failure to exec + 2001-12-13 Matthias Clasen * glib/gconvert.c, glib/giochannel.c, glib/gmain.c, diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4 index 2c5b889d..80fbeb37 100644 --- a/ChangeLog.pre-2-4 +++ b/ChangeLog.pre-2-4 @@ -1,3 +1,13 @@ +2001-12-14 Havoc Pennington + + * glib/gshell.c (g_shell_parse_argv): note on how to free returned + vector + +2001-12-08 Havoc Pennington + + * glib/gspawn.c (fork_exec_with_pipes): include argv[0] in error + message about failure to exec + 2001-12-13 Matthias Clasen * glib/gconvert.c, glib/giochannel.c, glib/gmain.c, diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6 index 2c5b889d..80fbeb37 100644 --- a/ChangeLog.pre-2-6 +++ b/ChangeLog.pre-2-6 @@ -1,3 +1,13 @@ +2001-12-14 Havoc Pennington + + * glib/gshell.c (g_shell_parse_argv): note on how to free returned + vector + +2001-12-08 Havoc Pennington + + * glib/gspawn.c (fork_exec_with_pipes): include argv[0] in error + message about failure to exec + 2001-12-13 Matthias Clasen * glib/gconvert.c, glib/giochannel.c, glib/gmain.c, diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8 index 2c5b889d..80fbeb37 100644 --- a/ChangeLog.pre-2-8 +++ b/ChangeLog.pre-2-8 @@ -1,3 +1,13 @@ +2001-12-14 Havoc Pennington + + * glib/gshell.c (g_shell_parse_argv): note on how to free returned + vector + +2001-12-08 Havoc Pennington + + * glib/gspawn.c (fork_exec_with_pipes): include argv[0] in error + message about failure to exec + 2001-12-13 Matthias Clasen * glib/gconvert.c, glib/giochannel.c, glib/gmain.c, diff --git a/glib/gshell.c b/glib/gshell.c index 3f6134b6..87ebaff6 100644 --- a/glib/gshell.c +++ b/glib/gshell.c @@ -579,7 +579,7 @@ tokenize_command_line (const gchar *command_line, * contains none of the unsupported shell expansions. If the input * does contain such expansions, they are passed through * literally. Possible errors are those from the #G_SHELL_ERROR - * domain. + * domain. Free the returned vector with g_strfreev(). * * Return value: TRUE on success, FALSE if error set **/ diff --git a/glib/gspawn.c b/glib/gspawn.c index f436b6ff..fd580b91 100644 --- a/glib/gspawn.c +++ b/glib/gspawn.c @@ -1119,7 +1119,8 @@ fork_exec_with_pipes (gboolean intermediate_child, g_set_error (error, G_SPAWN_ERROR, exec_err_to_g_error (buf[1]), - _("Failed to execute child process (%s)"), + _("Failed to execute child process \"%s\" (%s)"), + argv[0], g_strerror (buf[1])); break; @@ -1145,7 +1146,8 @@ fork_exec_with_pipes (gboolean intermediate_child, g_set_error (error, G_SPAWN_ERROR, G_SPAWN_ERROR_FAILED, - _("Unknown error executing child process")); + _("Unknown error executing child process \"%s\""), + argv[0]); break; } -- 2.34.1