From 81419b53deb63ced6bd388a9239f32ae2be29163 Mon Sep 17 00:00:00 2001 From: Tor Lillqvist Date: Sun, 24 Feb 2008 22:53:52 +0000 Subject: [PATCH] Mention that the recent fix to the gspawn helper process synchronization on Windows fixes #510664. svn path=/trunk/; revision=6577 --- ChangeLog | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/ChangeLog b/ChangeLog index 794ba71f..e9668cf9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -7,13 +7,15 @@ * glib/gspawn-win32.c * glib/gspawn-win32-helper.c: Fix race condition when using the - helper process: When the helper process writes the handle of the - actual started user process to the parent process, it must be - duplicated in the parent process with DuplicateHandle() so that it - is a valid handle in that process. However, if the helper process - has happened to exit before the DuplicateHandle() call, the - duplication will fail. Thus we must synchronise the helper - process's exit. Use another pipe for this. + helper process. This seems to fix #510664. + + When the helper process writes the handle of the actual started + user process to the parent process, it must be duplicated in the + parent process with DuplicateHandle() so that it is a valid handle + in that process. However, if the helper process has happened to + exit before the DuplicateHandle() call, the duplication will + fail. Thus we must synchronise the helper process's exit. Use + another pipe for this. Take care not to inherit the writing end of this pipe to the helper process. Also, in the helper process, take care not to -- 2.34.1