Upper half of byte is >> 4, not >> 8. Found by Kjartan Maraas via sparse

2008-10-10  Alexander Larsson  <alexl@redhat.com>

	* gfileattribute.c (escape_byte_string):
	Upper half of byte is >> 4, not >> 8.
	Found by Kjartan Maraas via sparse

svn path=/trunk/; revision=7590

diff --git a/gio/ChangeLog b/gio/ChangeLog
index 0ceb81a7729a364ade34c840fe86153c8f196508..744cd41acef2e3d5a40a2b4fb802850e18560586 100644 (file)
--- a/gio/ChangeLog
+++ b/gio/ChangeLog
@@ -1,3 +1,9 @@
+2008-10-10  Alexander Larsson  <alexl@redhat.com>
+
+       * gfileattribute.c (escape_byte_string):
+       Upper half of byte is >> 4, not >> 8.
+       Found by Kjartan Maraas via sparse
+
 2008-10-10  Matthias Clasen  <mclasen@redhat.com>
 
        Bug 555711 – Wrong fallback order of mimetype icons

diff --git a/gio/gfileattribute.c b/gio/gfileattribute.c
index 76bdf61196e421a91f2b0ebc7ed022afab3ef19d..338f8093db98d0f2b78bd84f18798e7728ada2a3 100644 (file)
--- a/gio/gfileattribute.c
+++ b/gio/gfileattribute.c
@@ -384,7 +384,7 @@ escape_byte_string (const char *str)
            {
              *p++ = '\\';
              *p++ = 'x';
-             *p++ = hex_digits[(c >> 8) & 0xf];
+             *p++ = hex_digits[(c >> 4) & 0xf];
              *p++ = hex_digits[c & 0xf];
            }
        }