03:29:57 <Mikachu> didn't your removal of the ==0 check introduce a call to

                   scr_page(UP)?
03:29:58 <schmorp> moa pls
03:30:04 <schmorp> it did
03:30:18 <schmorp> but if i coded that function, it will not crash
03:30:30 <schmorp> if i had coded that function it would have oen argument only, too :(

diff --git a/src/command.C b/src/command.C
index 86a81d6141681581df79fcf54e5c8e5d331a7cf5..705a4bafac88ddd8398bcfa4db7b8525f8e20bbc 100644 (file)
--- a/src/command.C
+++ b/src/command.C
@@ -1090,8 +1090,8 @@ rxvt_term::text_blink_cb (ev::timer &w, int revents)
 void
 rxvt_term::cont_scroll_cb (ev::timer &w, int revents)
 {
-  if ((scrollbar_isUp() || scrollbar_isDn()) &&
-      scr_page (scrollbar_isUp() ? UP : DN, 1))
+  if ((scrollbar_isUp () || scrollbar_isDn ())
+      && scr_page (scrollbar_isUp () ? UP : DN, 1))
     want_refresh = 1;
   else
     w.stop ();
@@ -1116,7 +1116,7 @@ rxvt_term::sel_scroll_cb (ev::timer &w, int revents)
 void
 rxvt_term::slip_wheel_cb (ev::timer &w, int revents)
 {
-  if (scr_page (mouse_slip_wheel_speed < 0 ? DN : UP, abs (mouse_slip_wheel_speed)))
+  if (scr_changeview (view_start - mouse_slip_wheel_speed))
     want_refresh = 1;
 
   if (view_start == top_row || view_start == 0 || mouse_slip_wheel_speed == 0)