mikachu/openbox.git
16 years agohandle locked windows in client list menus also. this is a really stupid way of doing it.
Mikael Magnusson [Thu, 19 Feb 2009 16:52:57 +0000 (17:52 +0100)]
handle locked windows in client list menus also. this is a really stupid way of doing it.

16 years agoStart on the second entry...
Mikael Magnusson [Sun, 8 Feb 2009 16:35:35 +0000 (17:35 +0100)]
Start on the second entry...

16 years agoOnly warp on menu close if it was also the top level menu.
Mikael Magnusson [Sun, 8 Feb 2009 16:35:26 +0000 (17:35 +0100)]
Only warp on menu close if it was also the top level menu.

16 years agoMerge branch 'mikabox/maybe' into wip/mikabox
Mikael Magnusson [Sun, 8 Feb 2009 07:52:07 +0000 (08:52 +0100)]
Merge branch 'mikabox/maybe' into wip/mikabox

Conflicts:
openbox/client_list_combined_menu.c

16 years agoWarp to the top of the combined menu and back.
Mikael Magnusson [Sun, 8 Feb 2009 07:51:25 +0000 (08:51 +0100)]
Warp to the top of the combined menu and back.

16 years agoPut current desktop on top of combined client list menu.
Mikael Magnusson [Fri, 6 Feb 2009 01:16:06 +0000 (02:16 +0100)]
Put current desktop on top of combined client list menu.

This probably needs an option.

16 years agoMerge branch 'work' into wip/mikabox
Mikael Magnusson [Mon, 2 Feb 2009 14:43:49 +0000 (15:43 +0100)]
Merge branch 'work' into wip/mikabox

Conflicts:
openbox/event.c

16 years agoMerge branch 'backport' into work
Mikael Magnusson [Thu, 29 Jan 2009 21:45:47 +0000 (22:45 +0100)]
Merge branch 'backport' into work

Conflicts:
openbox/event.c
openbox/frame.c

16 years agoAdd Plural-Forms header to .po files that need it.
Mikael Magnusson [Thu, 29 Jan 2009 21:35:25 +0000 (22:35 +0100)]
Add Plural-Forms header to .po files that need it.

16 years agoHandle InputShape type shaping too.
Mikael Magnusson [Thu, 29 Jan 2009 21:33:44 +0000 (22:33 +0100)]
Handle InputShape type shaping too.

Many composite apps use this to pass through clicks where they are transparent.

16 years agoTypos in error message from gdm-control
Mikael Magnusson [Sun, 23 Nov 2008 11:33:20 +0000 (12:33 +0100)]
Typos in error message from gdm-control

16 years agoinstall-sh should be executable
Mikael Magnusson [Sun, 23 Nov 2008 11:21:31 +0000 (12:21 +0100)]
install-sh should be executable

Apparently on solaris, you can't invoke -x scripts via "sh install-sh".

16 years agoMerge branch 'backport' into work
Mikael Magnusson [Wed, 19 Nov 2008 16:43:56 +0000 (17:43 +0100)]
Merge branch 'backport' into work

16 years agoOnly update the focus cycle indicator when already visible in frame.c to avoid overri...
Mikael Magnusson [Wed, 19 Nov 2008 16:14:38 +0000 (17:14 +0100)]
Only update the focus cycle indicator when already visible in frame.c to avoid overriding bar=no

16 years agoOnly update the focus cycle indicator when already visible in frame.c to avoid overri...
Mikael Magnusson [Wed, 19 Nov 2008 16:14:38 +0000 (17:14 +0100)]
Only update the focus cycle indicator when already visible in frame.c to avoid overriding bar=no

16 years agoAnother problem pointed out by clang
Mikael Magnusson [Mon, 10 Nov 2008 22:25:23 +0000 (23:25 +0100)]
Another problem pointed out by clang

Using format specifiers without arguments in printf is still bad.

openbox/debug.c:105:18: warning: format string is not a string literal (potentially insecure)
    fprintf(out, log_domain);
                 ^~~~~~~~~~
openbox/debug.c:107:18: warning: format string is not a string literal (potentially insecure)
    fprintf(out, level);
                 ^~~~~
openbox/debug.c:109:18: warning: format string is not a string literal (potentially insecure)
    fprintf(out, message);
                 ^~~~~~~

16 years agoMerge branch 'backport' into work
Mikael Magnusson [Sat, 15 Nov 2008 21:53:02 +0000 (22:53 +0100)]
Merge branch 'backport' into work

Conflicts:
openbox/event.c

16 years agoUse ngettext for %d desktop(s).
Mikael Magnusson [Sat, 15 Nov 2008 21:50:16 +0000 (22:50 +0100)]
Use ngettext for %d desktop(s).

This poses a small problem. We currently let translators reorder this
string, but ngettext only takes one numeric argument. This means that you
can either get correct pluralization or the order you want, but not both.

I fixed up the languages I understand at a very basic level, but the
rest will need translator assistance.

16 years agoFix a problem pointed out by clang
Mikael Magnusson [Mon, 10 Nov 2008 22:34:50 +0000 (23:34 +0100)]
Fix a problem pointed out by clang

openbox/client.c:269:10: warning: incompatible pointer types passing 'gint *', expected 'guint32 *'
    if (!OBT_PROP_GET32(self->window, NET_WM_USER_TIME, CARDINAL, &user_time))
         ^~~~~~~~~~~~~~

16 years agoMerge branch 'work' into wip/mikabox
Mikael Magnusson [Wed, 5 Nov 2008 18:36:16 +0000 (19:36 +0100)]
Merge branch 'work' into wip/mikabox

Conflicts:
openbox/event.c

16 years agoMerge branch 'backport' into work
Mikael Magnusson [Wed, 5 Nov 2008 18:35:18 +0000 (19:35 +0100)]
Merge branch 'backport' into work

16 years agoDon't move windows to current desktop on net_active_window if the event didn't come...
Mikael Magnusson [Wed, 5 Nov 2008 17:48:10 +0000 (18:48 +0100)]
Don't move windows to current desktop on net_active_window if the event didn't come from the user.

Instead, just activate the flashy thinger.

16 years agoUsing format specifiers without arguments in printf is bad.
Mikael Magnusson [Wed, 5 Nov 2008 18:09:34 +0000 (19:09 +0100)]
Using format specifiers without arguments in printf is bad.

16 years agoAdd GroupMembers action.
Mikael Magnusson [Fri, 31 Oct 2008 22:37:30 +0000 (23:37 +0100)]
Add GroupMembers action.

Similar to AllClients, but acts on all members of the group the current
action target is a member of.

16 years agoMerge branch 'work' into wip/mikabox
Mikael Magnusson [Wed, 29 Oct 2008 12:50:50 +0000 (13:50 +0100)]
Merge branch 'work' into wip/mikabox

Conflicts:
openbox/event.c

16 years agoMerge branch 'backport' into work
Mikael Magnusson [Wed, 29 Oct 2008 12:48:03 +0000 (13:48 +0100)]
Merge branch 'backport' into work

16 years agoBring helper windows when following a window.
Mikael Magnusson [Wed, 29 Oct 2008 12:30:26 +0000 (13:30 +0100)]
Bring helper windows when following a window.

16 years ago_NET_WM_USER_TIME=0 means don't focus the new window.
Mikael Magnusson [Wed, 29 Oct 2008 11:35:17 +0000 (12:35 +0100)]
_NET_WM_USER_TIME=0 means don't focus the new window.

16 years agoMerge branch 'backport' into work
Mikael Magnusson [Sun, 26 Oct 2008 23:58:56 +0000 (00:58 +0100)]
Merge branch 'backport' into work

Conflicts:
openbox/client.c
openbox/prop.c
openbox/prop.h

16 years agoNo \n on ob_debug in this branch.
Mikael Magnusson [Tue, 10 Jun 2008 15:55:03 +0000 (17:55 +0200)]
No \n on ob_debug in this branch.

16 years agoThe code to replace $wid/$pid died on $foo.
Mikael Magnusson [Sat, 7 Jun 2008 03:12:04 +0000 (05:12 +0200)]
The code to replace $wid/$pid died on $foo.

It failed to increment a variable after finding a $ but no pid or wid,
which led to a fun infinite loop. Also don't check if c[1] is w if we
already established it was p.

16 years agoShow name/class when mapping in debug mode.
Mikael Magnusson [Sun, 26 Oct 2008 23:51:56 +0000 (00:51 +0100)]
Show name/class when mapping in debug mode.

16 years agoRevert "make windows stay on screen when they..."
Mikael Magnusson [Sun, 4 May 2008 09:56:57 +0000 (11:56 +0200)]
Revert "make windows stay on screen when they..."

This reverts commit 73adc6480d59fc5dccf9fe19ed5234c9582b328c.
I know I had a good reason for reverting this commit, I don't know what
that reason was though.

16 years agoCorrect a 64-bit bug in event_time_after
Mikael Magnusson [Sun, 26 Oct 2008 23:10:57 +0000 (00:10 +0100)]
Correct a 64-bit bug in event_time_after

The code assumed the timestamps had the same domain as the type Xlib
uses for them, which is almost never the case with Xlib. Change all
involved variables to guint32.

16 years agogive the compiler hints about what can be kept in registers so that it can optimize...
Dana Jansens [Sat, 29 Mar 2008 00:56:16 +0000 (20:56 -0400)]
give the compiler hints about what can be kept in registers so that it can optimize the gradient code better with all the pointers going on

16 years agoMake sure the _MOTIF_WM_INFO atom exists.
Mikael Magnusson [Wed, 22 Oct 2008 19:13:27 +0000 (21:13 +0200)]
Make sure the _MOTIF_WM_INFO atom exists.

Without this, urxvt won't use motif hints for borderless mode.

16 years agoUpdate Basque translation.
Inko Illarramendi Arancibia [Wed, 22 Oct 2008 16:15:30 +0000 (18:15 +0200)]
Update Basque translation.

17 years agoMerge branch 'mikabox/actions' into wip/mikabox
Mikael Magnusson [Sat, 4 Oct 2008 22:04:58 +0000 (00:04 +0200)]
Merge branch 'mikabox/actions' into wip/mikabox

Conflicts:
openbox/actions/focus.c
openbox/event.c

17 years agoAdd "locked" to if action
Mikael Magnusson [Sat, 4 Oct 2008 22:04:10 +0000 (00:04 +0200)]
Add "locked" to if action

17 years agoDisallow some more stuff on locked windows
Mikael Magnusson [Sat, 4 Oct 2008 11:03:18 +0000 (13:03 +0200)]
Disallow some more stuff on locked windows

17 years agoMerge branch 'mikabox/maybe' into wip/mikabox
Mikael Magnusson [Sat, 4 Oct 2008 10:52:59 +0000 (12:52 +0200)]
Merge branch 'mikabox/maybe' into wip/mikabox

17 years agoDon't allow deiconifying locked windows via the focus action.
Mikael Magnusson [Sat, 4 Oct 2008 10:49:56 +0000 (12:49 +0200)]
Don't allow deiconifying locked windows via the focus action.

17 years agoCenter text in pager popup and make it at least as wide as it is high.
Mikael Magnusson [Sun, 28 Sep 2008 20:05:25 +0000 (22:05 +0200)]
Center text in pager popup and make it at least as wide as it is high.

17 years ago0 is the first monitor here, not 1.
Mikael Magnusson [Sun, 14 Sep 2008 11:56:13 +0000 (13:56 +0200)]
0 is the first monitor here, not 1.

17 years agoMerge branch 'imlib-submenus' into wip/mikabox
Mikael Magnusson [Wed, 10 Sep 2008 16:11:24 +0000 (18:11 +0200)]
Merge branch 'imlib-submenus' into wip/mikabox

17 years agoUnrelated to this topic but whatever. Refactor and comment and note some bugs that...
Mikael Magnusson [Wed, 10 Sep 2008 16:10:58 +0000 (18:10 +0200)]
Unrelated to this topic but whatever. Refactor and comment and note some bugs that should be fixed.

17 years agoMerge branch 'imlib-submenus' into wip/mikabox
Mikael Magnusson [Wed, 10 Sep 2008 15:17:51 +0000 (17:17 +0200)]
Merge branch 'imlib-submenus' into wip/mikabox

17 years agoIs this better or worse?
Mikael Magnusson [Wed, 10 Sep 2008 15:17:25 +0000 (17:17 +0200)]
Is this better or worse?

17 years agoXXX TODO BLAG ETC Allow icons also for submenus
Mikael Magnusson [Mon, 28 Apr 2008 22:25:20 +0000 (00:25 +0200)]
XXX TODO BLAG ETC Allow icons also for submenus

This has some code that should be "refactored" a bit.

17 years agoMerge commit 'nightm4re/3.4-working-padding' into wip/mikabox
Mikael Magnusson [Sat, 23 Aug 2008 04:59:55 +0000 (06:59 +0200)]
Merge commit 'nightm4re/3.4-working-padding' into wip/mikabox

17 years agoCheck both window+margin and just window for grow/move.
Dave Foster [Sat, 23 Aug 2008 04:59:37 +0000 (00:59 -0400)]
Check both window+margin and just window for grow/move.

17 years agoMerge commit 'nightm4re/3.4-working-padding' into wip/mikabox
Mikael Magnusson [Sat, 23 Aug 2008 04:42:54 +0000 (06:42 +0200)]
Merge commit 'nightm4re/3.4-working-padding' into wip/mikabox

17 years agoMerge commit 'nightm4re/3.4-working-padding' into wip/mikabox
Mikael Magnusson [Sat, 23 Aug 2008 04:32:31 +0000 (06:32 +0200)]
Merge commit 'nightm4re/3.4-working-padding' into wip/mikabox

17 years agoMika says rearrange it!
Dave Foster [Sat, 23 Aug 2008 04:36:03 +0000 (00:36 -0400)]
Mika says rearrange it!

17 years agoMerge branch '3.4' into wip/mikabox
Mikael Magnusson [Sat, 23 Aug 2008 04:32:25 +0000 (06:32 +0200)]
Merge branch '3.4' into wip/mikabox

17 years agoNeedless externs.
Dave Foster [Sat, 23 Aug 2008 04:28:40 +0000 (00:28 -0400)]
Needless externs.

17 years agoAdded <windowMargin> config item and made the margin thing respect it!
Dave Foster [Sat, 23 Aug 2008 04:20:37 +0000 (00:20 -0400)]
Added <windowMargin> config item and made the margin thing respect it!

17 years agoSilly commentating.
Dave Foster [Sat, 23 Aug 2008 03:54:07 +0000 (23:54 -0400)]
Silly commentating.

17 years agoMove now has resistance.
Dave Foster [Sat, 23 Aug 2008 03:29:23 +0000 (23:29 -0400)]
Move now has resistance.

17 years agoResist edges working with margin.
Dave Foster [Sat, 23 Aug 2008 03:13:15 +0000 (23:13 -0400)]
Resist edges working with margin.

17 years agoGrowToEdge functions respect windows having a margin the same as the desktop margin.
Dave Foster [Sat, 23 Aug 2008 02:58:51 +0000 (22:58 -0400)]
GrowToEdge functions respect windows having a margin the same as the desktop margin.

17 years agoAdd danish translation.
Jesper Sander [Tue, 19 Aug 2008 15:46:45 +0000 (17:46 +0200)]
Add danish translation.

17 years agoMerge branch 'buttons' into wip/mikabox
Mikael Magnusson [Sun, 13 Jul 2008 16:10:52 +0000 (18:10 +0200)]
Merge branch 'buttons' into wip/mikabox

Conflicts:
openbox/client_menu.c
openbox/framerender.c
render/render.c
render/render.h
render/theme.c
render/theme.h

17 years agoProperly escape strings before writing XML.
Nico Golde [Sun, 13 Jul 2008 13:29:50 +0000 (15:29 +0200)]
Properly escape strings before writing XML.

17 years agoThis might be a little bit better.
Mikael Magnusson [Mon, 7 Jul 2008 20:34:55 +0000 (22:34 +0200)]
This might be a little bit better.

At least it consistently doesn't run the openbox action.

17 years ago"Fix" releasing the mouse button over a window.
Mikael Magnusson [Mon, 7 Jul 2008 19:20:34 +0000 (21:20 +0200)]
"Fix" releasing the mouse button over a window.

Previously if you click-drag-released the left button on the root window to a client window,
Openbox would ignore the release because we don't own the client window. Now check if we
are in a button press or not before ignoring it. The bug was we would initiate a move when
the cursor was moved over a titlebar even when the button was unpressed because the variable
didn't get cleared properly.

This fix is very ugly.

17 years agoNo \n on ob_debug in this branch.
Mikael Magnusson [Tue, 10 Jun 2008 15:52:04 +0000 (17:52 +0200)]
No \n on ob_debug in this branch.

17 years agoShow name/class when mapping in debug mode.
Mikael Magnusson [Tue, 10 Jun 2008 15:51:53 +0000 (17:51 +0200)]
Show name/class when mapping in debug mode.

17 years agoMerge branch 'work' into wip/mikabox
Mikael Magnusson [Sat, 7 Jun 2008 03:16:07 +0000 (05:16 +0200)]
Merge branch 'work' into wip/mikabox

17 years agoThe code to replace $wid/$pid died on $foo.
Mikael Magnusson [Sat, 7 Jun 2008 03:12:04 +0000 (05:12 +0200)]
The code to replace $wid/$pid died on $foo.

It failed to increment a variable after finding a $ but no pid or wid,
which led to a fun infinite loop. Also don't check if c[1] is w if we
already established it was p. The code should probably check the length
of the string instead of reading random memory, but how fun is that?

17 years agoOpenbox doesn't support _NET_WM_USER_TIME_WINDOW atm.
Mikael Magnusson [Thu, 29 May 2008 16:51:17 +0000 (18:51 +0200)]
Openbox doesn't support _NET_WM_USER_TIME_WINDOW atm.

17 years agoUpdate catalan translation.
David Majà Martínez [Sun, 25 May 2008 18:26:24 +0000 (20:26 +0200)]
Update catalan translation.

17 years agoAdd a translators note about not translating the word "SessionLogout" in an error...
Mikael Magnusson [Sat, 24 May 2008 14:36:22 +0000 (16:36 +0200)]
Add a translators note about not translating the word "SessionLogout" in an error message.

17 years agoAdd turkish translation.
Tutku Dalmaz [Sat, 24 May 2008 14:33:49 +0000 (16:33 +0200)]
Add turkish translation.

17 years agoDo focus menus with the mouse.
Mikael Magnusson [Tue, 20 May 2008 16:22:24 +0000 (18:22 +0200)]
Do focus menus with the mouse.

17 years agoUpdate italian translation.
Andrea Scarpino [Thu, 15 May 2008 11:12:22 +0000 (13:12 +0200)]
Update italian translation.

17 years agoUpdate spanish translation.
Nicolás de la Torre [Sun, 4 May 2008 20:04:38 +0000 (22:04 +0200)]
Update spanish translation.

17 years agoAdd Lithuanian translation.
Mikael Magnusson [Sun, 4 May 2008 19:17:53 +0000 (21:17 +0200)]
Add Lithuanian translation.

17 years agoMerge branch 'work' into wip/mikabox
Mikael Magnusson [Sun, 4 May 2008 10:06:25 +0000 (12:06 +0200)]
Merge branch 'work' into wip/mikabox

17 years agoRevert "make windows stay on screen when they are resized due to their normal hints...
Mikael Magnusson [Sun, 4 May 2008 09:56:57 +0000 (11:56 +0200)]
Revert "make windows stay on screen when they are resized due to their normal hints changing"

This reverts commit 73adc6480d59fc5dccf9fe19ed5234c9582b328c.

17 years agoDon't translate action names.
Mikael Magnusson [Sat, 3 May 2008 13:03:04 +0000 (15:03 +0200)]
Don't translate action names.

17 years agoMerge branch 'backport' into work
Dana Jansens [Fri, 2 May 2008 17:44:26 +0000 (13:44 -0400)]
Merge branch 'backport' into work

17 years agoa 64-bit fix
Dana Jansens [Fri, 2 May 2008 15:01:38 +0000 (11:01 -0400)]
a 64-bit fix

17 years agogive the compiler hints about what can be kept in registers so that it can optimize...
Dana Jansens [Sat, 29 Mar 2008 00:56:16 +0000 (20:56 -0400)]
give the compiler hints about what can be kept in registers so that it can optimize the gradient code better with all the pointers going on

17 years agoUpdate russian translation.
Moroz Sergey L [Fri, 2 May 2008 08:26:40 +0000 (10:26 +0200)]
Update russian translation.

17 years agoAllow to use a pango font description string.
Mikael Magnusson [Tue, 29 Apr 2008 14:56:31 +0000 (16:56 +0200)]
Allow to use a pango font description string.

17 years agoMerge branch 'wip/edges' into wip/mikabox
Mikael Magnusson [Mon, 28 Apr 2008 22:26:47 +0000 (00:26 +0200)]
Merge branch 'wip/edges' into wip/mikabox

17 years agoThis & shouldn't be here.
Mikael Magnusson [Mon, 28 Apr 2008 22:26:18 +0000 (00:26 +0200)]
This & shouldn't be here.

17 years agoMerge branch 'imlib2' into wip/mikabox
Mikael Magnusson [Mon, 28 Apr 2008 22:08:57 +0000 (00:08 +0200)]
Merge branch 'imlib2' into wip/mikabox

Conflicts:

Makefile.am
openbox/config.c
openbox/menu.c

17 years agoThis patch implements support for icons in user-defined menus into Openbox
Kadlcik Libor [Tue, 25 Mar 2008 20:58:12 +0000 (21:58 +0100)]
This patch implements support for icons in user-defined menus into Openbox

Image loading is done using the Imlib2 library.
I chose Imlib2 because it's pretty fast, it's easy to use, supports many file
formats (tested xpm, gif, jpeg, png) and doesn't introduce too much bloat (it
depends :)).

I ported the patch to 3.4.7-pre3 and added some enhancements. Caching is much
better now, and icons can be disabled at compile time using --disable-imlib2
option.

What's new?
Syntax of configuration files (namely rc.xml and menu.xml) has been changed
slightly to allow users to associate icons to menu entries. This is done by
specifying path to icon file in the new "icon" attribute in "<item>" element,
e.g:
<item label="Vim" icon="/usr/share/pixmaps/vim-32.xpm">
  <action name="Execute"><execute>x-terminal-emulator -T Vim -e
vim</execute></action>
</item>

If user doesn't want to display any icons in his user-defined menus, he/she can
disable icons in rc.xml, inside "<menu>" section:
<menu>
 ...
  <showIcons>no</showIcons>
 ...
</menu>
Default value is "yes".
(New boolean variable "config_menu_user_show_icons" has been added to source
code.)

An icon is loaded (using menu_item_attach_icon()) when a new entry of menu is
created. Fortunately, I haven't notice any performance problems because of this
:).

17 years agoBump. release-3.4.7.2
Mikael Magnusson [Wed, 23 Apr 2008 15:18:01 +0000 (17:18 +0200)]
Bump.

17 years agoMerge branch 'work' into wip/mikabox
Mikael Magnusson [Wed, 23 Apr 2008 15:07:42 +0000 (17:07 +0200)]
Merge branch 'work' into wip/mikabox

Conflicts:

openbox/moveresize.c

17 years agoMerge branch 'backport' into work
Mikael Magnusson [Wed, 23 Apr 2008 14:41:35 +0000 (16:41 +0200)]
Merge branch 'backport' into work

Conflicts:

openbox/config.c
openbox/keyboard.c
openbox/moveresize.c

17 years agoFix typo introduced a few commits ago that made resizing windows hard.
Mikael Magnusson [Wed, 23 Apr 2008 14:40:22 +0000 (16:40 +0200)]
Fix typo introduced a few commits ago that made resizing windows hard.

17 years agoCrazy focus model.
Mikael Magnusson [Wed, 23 Apr 2008 14:25:50 +0000 (16:25 +0200)]
Crazy focus model.

17 years agoDon't need to explicitly check for xft.
Mikael Magnusson [Sat, 19 Apr 2008 22:10:52 +0000 (00:10 +0200)]
Don't need to explicitly check for xft.

17 years agoBump and changelog. release-3.4.7.1
Mikael Magnusson [Wed, 16 Apr 2008 15:35:27 +0000 (17:35 +0200)]
Bump and changelog.

17 years agoMissed a pair of parentheses when I resolved a merge conflict. You can now resize...
Mikael Magnusson [Wed, 16 Apr 2008 15:31:09 +0000 (17:31 +0200)]
Missed a pair of parentheses when I resolved a merge conflict. You can now resize windows again.

17 years agoBump version to 3.4.7. release-3.4.7
Mikael Magnusson [Tue, 15 Apr 2008 16:25:42 +0000 (18:25 +0200)]
Bump version to 3.4.7.

Remove an item from CHANGELOG as I just reverted that commit.

17 years agoMerge branch 'backport' into 3.4
Mikael Magnusson [Tue, 15 Apr 2008 16:18:09 +0000 (18:18 +0200)]
Merge branch 'backport' into 3.4